-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Final fixes for 5.2.0 release #2085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jhuleatt Here are the |
This comment has been minimized.
This comment has been minimized.
Publishing |
I'm happy with this build, cutting as |
No longer need to add all the deps and stuff in each package.json, simplify all this. Also indicate side effects for webpack to do it's thing. Pack after build too.
Cut |
Cutting |
FYI I've ported https://onsnapshot.com/ and everything is working great! https://github.com/jamesdaniels/onsnapshot |
Also I've had a bunch of people experimenting with the RCs here #2086 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chore(): final fixes for 5.2.0 release (angular#2085)
This PR serves as my working changes to 5.2 before release.
traceLast
is deceiving, as if there is time between the last emission and completion that time is counted. Name ittraceUntilComplete
instead.traceWhile
was just an opposite oftraceUntil
which doesn't do it's name justice. I've since super charged it,traceWhile
will trace starting with an emission that passes the test and ending with the first failure. It will also produce multiple traces, e.g,of(false, true, false, true, true, false).pipe(traceWhile('while', a => a))
will produce traces for the time between the 2nd and 3rd emission and the 4th and 6th emissions. Imagine it's use in a game loop:traceWhile('timePlaying', state => state.isPlaying && !state.isGameOver)
orComplete
options totraceUntil
andtraceWhile
^^^^^^^^^^
!traceComplete
has to be afterfirst
asisStable
itself is not completingAngularFirePerformance
was not eagerly initializing performance monitoringAngularFirePerformance
ng add
stepng add
more forgiving if they already have a.firebaserc
orfirebase.json
AngularFirePerformance
lazy and replacing dynamic import withempty()
in the UMDfirebase/messaging
withempty()
in the UMD, fixes AngularFireMessaging keeps Universal from compiling #1938