Skip to content

Final fixes for 5.2.0 release #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
May 31, 2019
Merged

Final fixes for 5.2.0 release #2085

merged 30 commits into from
May 31, 2019

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented May 24, 2019

This PR serves as my working changes to 5.2 before release.

  • traceLast is deceiving, as if there is time between the last emission and completion that time is counted. Name it traceUntilComplete instead.
  • traceWhile was just an opposite of traceUntil which doesn't do it's name justice. I've since super charged it, traceWhile will trace starting with an emission that passes the test and ending with the first failure. It will also produce multiple traces, e.g, of(false, true, false, true, true, false).pipe(traceWhile('while', a => a)) will produce traces for the time between the 2nd and 3rd emission and the 4th and 6th emissions. Imagine it's use in a game loop: traceWhile('timePlaying', state => state.isPlaying && !state.isGameOver)
  • Added orComplete options to traceUntil and traceWhile
  • Needed carets on the versions ^^^^^^^^^^!
  • Collection doc path should be optional
  • traceComplete has to be after first as isStable itself is not completing
  • AngularFirePerformance was not eagerly initializing performance monitoring
  • Ack, my performance operators weren't lazy! Fixed
  • Inject the default app into AngularFirePerformance
  • Dropped the Angular 8.0-rc from package.json as it's released now
  • Moving all the deps from the schematic to peer and adding them during the ng add step
  • Making the ng add more forgiving if they already have a .firebaserc or firebase.json
  • Added ng7 and ng8 build tests
  • Dropped unneeded stuff from the ngmodule package.json bringing them back inline with APF, though should update to AFP v8
  • Indicate side effects so webpack doesn't wreak us
  • Making AngularFirePerformance lazy and replacing dynamic import with empty() in the UMD
  • Replacing dynamic import of firebase/messaging with empty() in the UMD, fixes AngularFireMessaging keeps Universal from compiling #1938

@jamesdaniels jamesdaniels changed the title WIP 5.2 beta fixes WIP 5.2 final push May 24, 2019
@jamesdaniels
Copy link
Member Author

@jhuleatt Here are the traceWhile changes I mentioned.

@jamesdaniels

This comment has been minimized.

@jamesdaniels
Copy link
Member Author

jamesdaniels commented May 24, 2019

Publishing 5.2.0-beta.6 to @next with above fixes.

@jamesdaniels jamesdaniels changed the title WIP 5.2 final push Release 5.2.0 May 25, 2019
@jamesdaniels jamesdaniels changed the title Release 5.2.0 Final fixes for 5.2.0 release May 25, 2019
@jamesdaniels jamesdaniels added this to the 5.2.0 milestone May 25, 2019
@jamesdaniels
Copy link
Member Author

I'm happy with this build, cutting as 5.2.0-rc.1

@jamesdaniels
Copy link
Member Author

Cut 5.2.0-rc.2

@jamesdaniels jamesdaniels requested a review from jhuleatt May 30, 2019 18:02
@jamesdaniels
Copy link
Member Author

Cutting 5.2.0-rc.3 which utilizes dynamic import for performance monitoring & fixes both the performance and messaging modules in server builds (replacing from(import('firebase/messaging')) with empty() in the UMD).

@jamesdaniels
Copy link
Member Author

FYI I've ported https://onsnapshot.com/ and everything is working great! https://github.com/jamesdaniels/onsnapshot

@jamesdaniels
Copy link
Member Author

Also I've had a bunch of people experimenting with the RCs here #2086

Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesdaniels jamesdaniels merged commit 8e5a995 into master May 31, 2019
@jamesdaniels jamesdaniels deleted the 5.2-beta-fixes branch May 31, 2019 18:46
peterennis added a commit to peterennis/angularfire2 that referenced this pull request Jun 1, 2019
chore(): final fixes for 5.2.0 release (angular#2085)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AngularFireMessaging keeps Universal from compiling
5 participants